Skip to content

issue with windows build lerna #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BSd3v wants to merge 6 commits into
base: dev
Choose a base branch
from
+41 −4
Open

issue with windows build lerna #3427

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
677e4c1
issue with windows build lerna
BSd3v Sep 2, 2025
03c7a1c
switching lerna scope
BSd3v Sep 2, 2025
51bf3e9
Merge branch 'dev' into fix-windows
BSd3v Sep 2, 2025
e17de19
Merge branch 'dev' into fix-windows
BSd3v Sep 3, 2025
c487fcd
Merge branch 'dev' into fix-windows
BSd3v Jan 12, 2026
dab96bd
adjustment for the split command
BSd3v Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,43 @@ jobs:
path: packages/ # Upload the contents of the dist directory
retention-days: 1 # Keep artifact for 1 day (adjust as needed)

build-windows:
name: Build Dash Package - Windows
runs-on: windows-latest
timeout-minutes: 30
outputs:
artifact_name: dash-packages
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Node.js for frontend build
uses: actions/setup-node@v4
with:
node-version: '20'
cache: npm

- name: Install NPM dependencies
run: npm ci

- name: Set up Python for build
uses: actions/setup-python@v5
with:
python-version: '3.12'
cache: pip

- name: Install build dependencies
run: |
python -m pip install --upgrade pip
python -m pip install "setuptools<80.0.0"
python -m pip install build wheel
python -m pip install -e .[dev,ci]

- name: Build Dash
run: npm run first-build

test-typing:
name: Typing Tests
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions dash/development/update_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def bootstrap_components(components_source, concurrency, install_type):
else "{dash-core-components,dash-html-components,dash-table}"
)

cmdstr = f"npx lerna exec --concurrency {concurrency} --scope='{source_glob}' -- npm {install_type}"
cmdstr = f"npx lerna exec --concurrency {concurrency} --scope={source_glob} -- npm {install_type}"
Copy link
Contributor

@T4rk1n T4rk1n Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed those '' for spaces that might be in the directory path, while ' is not windows compatible, " is and work on both os.

Copy link
Contributor Author

@BSd3v BSd3v Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it, and it did not work.

Copy link
Contributor Author

@BSd3v BSd3v Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an issue with the posix, needed to be passed True

cmd = shlex.split(cmdstr, posix=not is_windows)
status_print(cmdstr)

Expand Down Expand Up @@ -79,7 +79,7 @@ def build_components(components_source, concurrency):
else "{dash-core-components,dash-html-components,dash-table}"
)

cmdstr = f"npx lerna exec --concurrency {concurrency} --scope='{source_glob}' -- npm run build"
cmdstr = f"npx lerna exec --concurrency {concurrency} --scope={source_glob} -- npm run build"
cmd = shlex.split(cmdstr, posix=not is_windows)
status_print(cmdstr)

Expand Down
Loading