-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add hidden to clientside callbacks as configurable parameter #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
dash/_callback.py
Outdated
| None, | ||
| prevent_initial_call, | ||
| no_output=no_output, | ||
| hidden=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand why it is mandatory to set it to True here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, it should be taken from the args, not hide all the clientside callbacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
T4rk1n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should take the hidden parameter from the arguments.
dash/_callback.py
Outdated
| None, | ||
| prevent_initial_call, | ||
| no_output=no_output, | ||
| hidden=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, it should be taken from the args, not hide all the clientside callbacks
Added
hiddento clientside callbacks as configurable parameter.Now it can be configured from
cilentside_callbackfunction.Solves this issue: #3525
Contributor Checklist