Skip to content

Add dummy 'wheel' event handler to enable scroll zoom on safari #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 18, 2025
Merged

Add dummy 'wheel' event handler to enable scroll zoom on safari #7474

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
06c3e7f
add dummy 'wheel' event handler to enable scroll zoom on safari
emilykl Jul 17, 2025
e6618c6
move dummy scroll listener to Events.init()
emilykl Jul 17, 2025
3ebf3bd
use conditional chaining instead of if statement
emilykl Jul 18, 2025
b142a3d
use newer acorn version for bundling, to support newer JS syntax
emilykl Jul 18, 2025
4a54374
add draftlog
emilykl Jul 18, 2025
b5deb4d
Update draftlogs/7474_fix.md
emilykl Jul 18, 2025
76c855d
return to if statement for checking existence of addEventListener
emilykl Jul 18, 2025
72c2269
Revert "use newer acorn version for bundling, to support newer JS syn…
emilykl Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/7474_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix scroll wheel zoom for choropleth maps in Safari [#7474](https://github.com/plotly/plotly.js/pull/7474)
28 changes: 16 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,5 +178,10 @@
"transform-loader": "^0.2.4",
"true-case-path": "^2.2.1",
"virtual-webgl": "^1.0.6"
},
"overrides": {
"falafel": {
"acorn": "^8.1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel comfortable introducing overriding dependencies like that in this PR, specially if we want to release a patch.
IMHO This should be discussed in a separate PR.
I suggest we use bring back the if statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll put back the if statement for now and open a separate PR for discussing upgrading acorn.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archmoj @camdecoster I have opened #7478 regarding the acorn override

}
}
}
}
8 changes: 8 additions & 0 deletions src/lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@ var Events = {
internalEv.emit(event, data);
};

/*
* Add a dummy event handler for 'wheel' event for Safari
* to enable mouse wheel zoom.
* https://github.com/d3/d3/issues/3035
* https://github.com/plotly/plotly.js/issues/7452
*/
plotObj?.addEventListener?.("wheel", () => {});

return plotObj;
},

Expand Down