Skip to content

Conversation

@emilykl
Copy link
Contributor

@emilykl emilykl commented Oct 8, 2025

Closes #7463, closes #6362

Resolves issue where shapes referenced to the domain of an axis id containing a zero (e.g. ref: 'x10 domain') were not clipped to the boundaries of the subplot, as they should have been.

Also adds an image mock for this issue to prevent regression.

Thanks to @Ike-lag and @DataScienceIsCool for reporting, and to @Ike-lag for identifying the faulty regex in the codebase!

Before:
7463_before

After:
7463_after

Steps for testing

  1. View the new zz_shapes_clipping_double_digit_subplots mock in the devtools dashboard (after running npm run build) and make sure the shapes in the lower-left subplot do not extend beyond the subplot boundaries
  2. If you want to see what the mock looks like on master, check out master, copy over the zz_shapes_clipping_double_digit_subplots.json file into the mocks dir, run npm run build and then check the mock in the devtools dashboard.

@emilykl emilykl force-pushed the fix-7463-shape-clipping-double-digit-subplots branch from d083982 to 61c113b Compare October 8, 2025 19:41
@gvwilson gvwilson requested a review from camdecoster October 9, 2025 12:15
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Oct 9, 2025
@emilykl emilykl merged commit 49898bc into master Oct 9, 2025
6 checks passed
@emilykl emilykl deleted the fix-7463-shape-clipping-double-digit-subplots branch October 9, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix fixes something broken P1 needed for current cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subplots not correctly clipping vrects every 10th subplot make_subplots + hrect rendering bug

4 participants