Skip to content

Conversation

robertoffmoura
Copy link
Contributor

Hi,

This fixes the issue where a matplotlib figure with only bottom and left tick markers would be converted to a plotly figure with markers on all sides.

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@robertoffmoura robertoffmoura force-pushed the rm/fix-tick-marker-mirroring branch 2 times, most recently from 3fafa67 to daf0327 Compare August 8, 2025 11:06
@gvwilson gvwilson requested a review from emilykl August 11, 2025 17:07
@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Aug 11, 2025
@robertoffmoura robertoffmoura force-pushed the rm/fix-tick-marker-mirroring branch from 860b8b0 to 001ff53 Compare August 12, 2025 09:31
@emilykl
Copy link
Contributor

emilykl commented Oct 1, 2025

Hi @robertoffmoura, thank you for the fix! Same question here, could you provide some side-by-side comparisons to show the difference this PR introduces and why this is the correct behavior? I'm not very familiar with axis mirroring in matplotlib (or Plotly for that matter) so just trying to sanity check that these changes make sense.

I took a quick look at the images of the plots in the tests you added, and the only one where I see a difference between your branch and main is in the axis_mirror_false_with_one_sided_ticks function, is that expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution fix fixes something broken P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants