-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update release instructions #5364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -3,7 +3,7 @@ | |||||||||||||||||
|
||||||||||||||||||
## Release process - full release of `plotly` package | ||||||||||||||||||
|
||||||||||||||||||
This is the release process for releasing `plotly.py` version `X.Y.Z`, including changelogs, Github release and forum announcement. | ||||||||||||||||||
This is the release process for releasing Plotly.py version `X.Y.Z`, including changelogs, GitHub release and forum announcement. | ||||||||||||||||||
|
||||||||||||||||||
### Finalize changelog | ||||||||||||||||||
|
||||||||||||||||||
|
@@ -13,59 +13,100 @@ Make sure the changelog includes the version being published at the top, along | |||||||||||||||||
with the expected publication date. | ||||||||||||||||||
|
||||||||||||||||||
Use the `Added`, `Changed`, `Deprecated`, `Removed`, `Fixed`, and `Security` | ||||||||||||||||||
labels for all changes to plotly.py. If the version of plotly.js has | ||||||||||||||||||
labels for all changes to Plotly.py. If the version of Plotly.js has | ||||||||||||||||||
been updated, include this as the first `Updated` entry. Call out any | ||||||||||||||||||
notable changes as sub-bullets (new trace types in particular), and provide | ||||||||||||||||||
a link to the plotly.js CHANGELOG. | ||||||||||||||||||
a link to the Plotly.js CHANGELOG. | ||||||||||||||||||
|
||||||||||||||||||
### Finalize versions | ||||||||||||||||||
### Update version numbers | ||||||||||||||||||
|
||||||||||||||||||
**Create a branch `git checkout -b release-X.Y.Z` *from the tip of `origin/main`*.** | ||||||||||||||||||
**Create a release branch `git checkout -b release-X.Y.Z` _from the tip of `origin/main`_.** | ||||||||||||||||||
|
||||||||||||||||||
Manually update the versions to `X.Y.Z` in the files specified below. | ||||||||||||||||||
- Manually update the versions to `X.Y.Z` in the files specified below: | ||||||||||||||||||
- `pyproject.toml` | ||||||||||||||||||
- update version | ||||||||||||||||||
- `CHANGELOG.md` | ||||||||||||||||||
- update version and release date | ||||||||||||||||||
- finalize changelog entries according to instructions above | ||||||||||||||||||
- `CITATION.cff` | ||||||||||||||||||
- update version and release date | ||||||||||||||||||
- Run `uv lock` to update the version number in the `uv.lock` file (do not update manually) | ||||||||||||||||||
- Commit and push your changes to the release branch: | ||||||||||||||||||
- `git add -u` | ||||||||||||||||||
- `git commit -m "version changes for vX.Y.Z"` | ||||||||||||||||||
- `git push` | ||||||||||||||||||
|
- `git add -u` | |
- `git commit -m "version changes for vX.Y.Z"` | |
- `git push` | |
```sh | |
git add -u | |
git commit -m "version changes for vX.Y.Z" | |
git push | |
``` |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, the closing ``` isn't showing up in the suggestion for some reason.
- `git tag vX.Y.Z` | |
- `git push origin vX.Y.Z` | |
```sh | |
git tag vX.Y.Z | |
git push origin vX.Y.Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some context or add instructions for who to contact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc is public so I'm not sure it makes sense to put more info here, but feel free to suggest different wording if you have an idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Good point. Ignore this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should maintain plotly.py and plotly.js to match what's shown in the repos. Was there something that prompted the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "to match what's shown in the repos"?
I changed it because I think the capitals make it easier to read, but I could be convinced otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that we refer to the libraries as "plotly.xy" instead of "Plotly.xy" in the README for each repo. It's not a big deal, but I always try to use the proper name for an item. Like "GitHub" instead of "Github".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah fair enough, I guess we should keep lowercase unless/until we change the styling across the board.