build and fetch JS/CSS assets using npm instead of Composer #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Composer to fetch Node modules allows us to use a single build tool to assemble the plugin. However, the Composer package is not really usable for deployment without pulling dev-dependencies, too. Asset Packagist has issues fetching Chartist artifacts and we require a mix of 2 build tools anyway. Fetch npm packages using npm and move the minification steps to Node as well, so we have 2 build/lint/test steps for PHP and JS/CSS.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Composer to fetch Node modules allows us to use a single build tool to assemble the plugin. However, the Composer package is not really usable for deployment without pulling dev-dependencies, too.
Asset Packagist has issues fetching Chartist artifacts and we require a mix of 2 build tools anyway.
Fetch npm packages using npm and move the minification steps to Node as well, so we have 2 build/lint/test steps for PHP and JS/CSS.