Skip to content

Conversation

@laurenskling
Copy link
Contributor

What does it do?

Allow the slugify function to be set via config

Why is it needed?

Right now kebab deburr toLower is hardcoded as a sanitizer. One might want to sanitize themselves. (for example, allow slashes)

How to test it?

It should default to the original function in the config.
or set a different function in the config. This can be @sindresorhus/slugify or a custom function

Related issue(s)/PR(s)

closes #184

@laurenskling
Copy link
Contributor Author

I don't currently how to build and run the codebase (yet). So I'm hard assuming this code works ;)

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2025

⚠️ No Changeset found

Latest commit: 44f8d18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boazpoolman boazpoolman merged commit 36816ea into pluginpal:master Mar 17, 2025
2 of 4 checks passed
@laurenskling laurenskling deleted the feature/slugify branch March 18, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could we use an actual slugify?

2 participants