Skip to content

Conversation

@jorrit
Copy link
Contributor

@jorrit jorrit commented Jun 26, 2025

What does it do?

The PR fixes all issues found by tsc --noEmit and adds a step to the lint workflow.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: b917017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
strapi-plugin-webtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.10%. Comparing base (8ad7fbe) to head (b917017).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   43.24%   43.10%   -0.14%     
==========================================
  Files           2        2              
  Lines         629      638       +9     
  Branches      156      157       +1     
==========================================
+ Hits          272      275       +3     
- Misses        285      291       +6     
  Partials       72       72              
Flag Coverage Δ
unit 43.10% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Jorrit!

@boazpoolman boazpoolman merged commit c098a92 into pluginpal:master Jun 26, 2025
7 of 8 checks passed
@pluginpal-bot pluginpal-bot mentioned this pull request Jun 26, 2025
@jorrit jorrit deleted the tscheck branch June 26, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants