Show spinner when bulk generating aliases #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0dfc272 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorrit
force-pushed
the
bulkgenfixes
branch
2 times, most recently
from
91012af to
53c3bac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 40.98% 40.87% -0.11%
==========================================
Files 2 2
Lines 627 614 -13
Branches 148 146 -2
==========================================
- Hits 257 251 -6
+ Misses 296 290 -6
+ Partials 74 73 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jorrit
changed the title
Contributor
Author
|
I have no idea how the code coverage is calculated. It only shows a file in the sitemap package. |
boazpoolman
approved these changes
Jul 22, 2025
Member
boazpoolman
left a comment
boazpoolman
left a comment
There was a problem hiding this comment.
This is great. Thanks @jorrit <3
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The primary goal was to show a spinner on the 'Bulk generate' button when generating. I also added some cosmetic changes in separate commits.
Why is it needed?
It's easy to accidently click twice on the Bulk generate button as it provides no feedback. When this process is started twice, the results are either no or duplicate aliases.
How to test it?
Start the playground, click the Bulk generate button. It should show a spinner.