Fixes for installations/content types without i18n #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f1ca00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 40.87% 40.48% -0.40%
==========================================
Files 2 2
Lines 614 615 +1
Branches 146 149 +3
==========================================
- Hits 251 249 -2
- Misses 290 295 +5
+ Partials 73 71 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I've added some more commits for small fixes and to get the playground working on Windows. |
jorrit
changed the title
Yalc uses the `LOCALAPPDATA` environment variable to determine where to put local packages. Without this change, turbo does not propagate `LOCALAPPDATA` to the `build` commands in packages. The packages get published to ``%HOME%\.yalc` instead of `%LOCALAPPDATA%\Yalc`. This means that `playground:publish` will not find them in `%LOCALAPPDATA%\Yalc`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
My PR #291 causes a bug when updating / bulk generating documents that have no locale.
Why is it needed?
When updating a documents alias without a locale, a
-0is always appended.How to test it?
Create a content type without internationalization and create a document with that type. Then update it.