Skip to content

Conversation

@TMSchipper
Copy link
Collaborator

No description provided.

@TMSchipper TMSchipper requested a review from boazpoolman August 4, 2025 19:41
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

⚠️ No Changeset found

Latest commit: d0fa92f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TMSchipper 👋

Thank you for putting up the MR. These 'search' endpoints seem like a nice addition to the plugin.

I've left some comments on your code, please let me know if you have any questions or need clarification about my feedback. In addition to that there are also some linting issues that need to be solved. Primarily the @typescript-eslint rules are giving some trouble.

When you're done, please don't forget to add a Changeset to make sure your change gets scheduled for publication 🙂

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TMSchipper.

I think we're almost there! I've left a couple comments but please notice that there are also still some linting errors that need to be fixed.

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TMSchipper,

I've just left one small comment. Other than that you still have to fix the pipeline issues and create a changeset for this change to be released. We're almost there!

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.37%. Comparing base (9ded83b) to head (d0fa92f).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   40.48%   39.37%   -1.11%     
==========================================
  Files           2        2              
  Lines         615      645      +30     
  Branches      149      163      +14     
==========================================
+ Hits          249      254       +5     
- Misses        295      309      +14     
- Partials       71       82      +11     
Flag Coverage Δ
unit 39.37% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@boazpoolman boazpoolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@boazpoolman boazpoolman merged commit 324ec80 into master Sep 4, 2025
7 of 8 checks passed
@boazpoolman boazpoolman deleted the feature/new-addons branch September 4, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants