-
-
Notifications
You must be signed in to change notification settings - Fork 21
feat: add search controller + search and reverseSearch methods #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TMSchipper 👋
Thank you for putting up the MR. These 'search' endpoints seem like a nice addition to the plugin.
I've left some comments on your code, please let me know if you have any questions or need clarification about my feedback. In addition to that there are also some linting issues that need to be solved. Primarily the @typescript-eslint rules are giving some trouble.
When you're done, please don't forget to add a Changeset to make sure your change gets scheduled for publication 🙂
boazpoolman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TMSchipper.
I think we're almost there! I've left a couple comments but please notice that there are also still some linting errors that need to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TMSchipper,
I've just left one small comment. Other than that you still have to fix the pipeline issues and create a changeset for this change to be released. We're almost there!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 40.48% 39.37% -1.11%
==========================================
Files 2 2
Lines 615 645 +30
Branches 149 163 +14
==========================================
+ Hits 249 254 +5
- Misses 295 309 +14
- Partials 71 82 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cf30739 to
31ee1c8
Compare
086f11c to
9cd4265
Compare
boazpoolman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
No description provided.