Skip to content

Remove redundant WHERE criteria #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btry merged 1 commit into from
Feb 3, 2026
Merged

Remove redundant WHERE criteria #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Toolbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,11 +511,11 @@ public static function findTemporalGapsInTable(string $table, DateTimeInterface
'date AS `end`'
],
'FROM' => $records_query,
'WHERE' => array_merge($boundaries, [
'WHERE' => [
'NOT' => ['prev_date' => null],
// new QueryExpression('TIMESTAMPDIFF(SECOND, `records`.`prev_date`, `records`.`date`) > ' . $interval_in_seconds)
new QueryExpression('DATE_ADD(`records`.`prev_date`, ' . $sql_interval . ') < `date`')
]),
],
],

// Gap before the beginning of the serie
Expand Down