Skip to content

fix(import): Export sections in logical order to fix condition import #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: support/2.13.0
Choose a base branch
from
+9 −2
Open

fix(import): Export sections in logical order to fix condition import #3618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
378e60d
fix(import): Export sections in logical order to fix condition import
MyvTsv Oct 20, 2025
29c2b31
Apply suggestion from @Rom1-B
Rom1-B Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions inc/exportabletrait.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,16 @@ public function exportChildrenObjects(array $subItems, array $export, bool $remo
}
$export[$key] = [];
foreach ($itemtypes as $itemtype) {
$allSubItems = $DB->request($itemtype::getSQLCriteriaToSearchForItem($this->getType(), $this->getID()));
$list = [];
$criteria = $itemtype::getSQLCriteriaToSearchForItem($this->getType(), $this->getID());

// Add ORDER BY clause if the itemtype has an 'order' field
// This ensures sections and other ordered items are exported in the correct order
$subItem = new $itemtype();
if ($subItem->isField('order')) {
$criteria['ORDER'] = ['order ASC'];
}
$allSubItems = $DB->request($criteria);
$list = [];
foreach ($allSubItems as $row) {
$subItem->getFromDB($row['id']);
$list[] = $subItem->export($remove_uuid);
Expand Down