fix(pdf): clean HTML tables to fit PDF page width to avoid overflow #52
+69
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rom1-B
requested changes
Nov 13, 2025
Comment on lines
+401
to
+411
| // Remove ALL width styles from elements (including px, %, em, etc.) | ||
| $html = preg_replace('/\bwidth\s*:\s*[^;"\'>]+;?/i', '', $html); | ||
|
|
||
| // Remove ALL height styles from elements | ||
| $html = preg_replace('/\bheight\s*:\s*[^;"\'>]+;?/i', '', $html); | ||
|
|
||
| // Remove width attributes from any tag | ||
| $html = preg_replace('/(<[^>]+)\s+width\s*=\s*["\']?[^"\'\s>]+["\']?/i', '$1', $html); | ||
|
|
||
| // Remove height attributes from any tag | ||
| $html = preg_replace('/(<[^>]+)\s+height\s*=\s*["\']?[^"\'\s>]+["\']?/i', '$1', $html); |
There was a problem hiding this comment.
For tables, it’s best to limit changes to what is strictly necessary and to make targeted modifications, even if it means adding further adjustments later. For instance, downsized images might lose their formatting if all size properties are removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply these fixes for GLPI 11 compatibility
#41
#50
#51
Screenshots (if appropriate):