Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Dec 11, 2025

Summary by CodeRabbit

  • Refactor
    • Adjusted how the Schedule selector is categorized so it no longer appears as a configuration-only control, affecting its visibility/placement in the UI.
  • Chores
    • Bumped the integration version to 0.62.1a0.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Walkthrough

Removed the entity_category=EntityCategory.CONFIG attribute from the SELECT_SCHEDULE Plugwise select entity; additionally bumped the integration/project version from 0.62.0 to 0.62.1a0 in manifest and pyproject files.

Changes

Cohort / File(s) Change Summary
Select entity attribute
custom_components/plugwise/select.py
Removed entity_category=EntityCategory.CONFIG from the SELECT_SCHEDULE entry in SELECT_TYPES.
Version bumps
custom_components/plugwise/manifest.json, pyproject.toml
Updated version from 0.62.0 to 0.62.1a0. No other metadata or logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small, focused edits across three files.
  • Review attention:
    • custom_components/plugwise/select.py: confirm intent for removing entity category and any downstream effects in Home Assistant entity grouping or UI.
    • manifest.json and pyproject.toml: ensure version consistency and release process alignment.

Suggested labels

require-dev-pass

Suggested reviewers

  • CoMPaTech

Poem

I nibble code with careful paws,
A tiny change without a pause,
A config tag hopped off the fence,
Versions nudged in gentle sense —
Hoppity-hop, the update’s done! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting the removal of entity_category from SELECT_SCHEDULE in select.py.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-therm-select

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a55ffd4 and 9bdeead.

📒 Files selected for processing (2)
  • custom_components/plugwise/manifest.json (1 hunks)
  • pyproject.toml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pyproject.toml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-08T15:35:25.180Z
Learnt from: bouwew
Repo: plugwise/plugwise-beta PR: 734
File: tests/components/plugwise/test_config_flow.py:58-58
Timestamp: 2024-10-08T15:35:25.180Z
Learning: In `tests/components/plugwise/test_config_flow.py`, the versions are mocked firmware versions for testing purposes and do not need to match the software version in `manifest.json`.

Applied to files:

  • custom_components/plugwise/manifest.json
🔇 Additional comments (1)
custom_components/plugwise/manifest.json (1)

11-11: No action required. Version consistency is confirmed across manifest.json and pyproject.toml (both at 0.62.1a0), and the entity_category has been properly removed from SELECT_SCHEDULE in select.py.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bouwew bouwew force-pushed the revert-therm-select branch from aeabc27 to 9bdeead Compare December 11, 2025 09:49
@sonarqubecloud
Copy link

@bouwew
Copy link
Contributor Author

bouwew commented Dec 14, 2025

Replaced by #988

@bouwew bouwew closed this Dec 14, 2025
@bouwew bouwew deleted the revert-therm-select branch December 14, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants