Bugfixes and improvements via plugwise_usb to v0.44.9 #294
Conversation
|
Warning Rate limit exceeded@bouwew has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 43 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughThis update increments the version numbers for the project and the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
pyproject.toml (1)
27-27: Pin minimum plugwise-usb version for consistency
pyproject.tomlstill allows anyplugwise-usbversion. To keep the runtime environment aligned with the manifest/test requirements, declare at least the new minimum:-dependencies = ["homeassistant", "plugwise-usb"] +dependencies = ["homeassistant", "plugwise-usb>=0.44.9"]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.md(1 hunks)custom_components/plugwise_usb/manifest.json(1 hunks)pyproject.toml(1 hunks)requirements_test.txt(1 hunks)
🔇 Additional comments (3)
requirements_test.txt (1)
7-7: Version bump looks goodDependency reference updated to 0.44.9 and the URL resolves to PyPI’s asset layout – no functional issues spotted.
pyproject.toml (1)
3-3: Project version bump acknowledgedVersion string increment to
0.55.6is consistent with the rest of the metadata.CHANGELOG.md (1)
5-8: Changelog entry reads wellEntry accurately records the 0.55.6 release and dependency bump.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
CHANGELOG.md (1)
5-8: Heading level breaks the existing hierarchyPrevious releases are recorded with
### v0.xx.x; the new entry uses##, which jumps a level and will render incorrectly in most Markdown viewers.-## v0.55.6 - 2025-07-24 +### v0.55.6 - 2025-07-24pyproject.toml (1)
3-3: Consider pinningplugwise-usbto the same version as the integrationThe manifest & tests target
plugwise-usb==0.44.9, while the core dependency list is still unpinned.
Pinning (or at least specifying a minimum) avoids accidental breakage when 0.45.0 lands.-dependencies = ["homeassistant", "plugwise-usb"] +dependencies = [ + "homeassistant", + "plugwise-usb>=0.44.9,<0.45", +]requirements_test.txt (1)
6-8: Prefer a simple version spec over a hard-coded tarball URLDirect URLs are brittle (hash-path changes, mirrors, wheels, etc.). A plain spec keeps
pip --upgradeworkflows working.-plugwise-usb @ https://files.pythonhosted.org/.../plugwise_usb-0.44.9.tar.gz +plugwise-usb==0.44.9
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.md(1 hunks)custom_components/plugwise_usb/manifest.json(1 hunks)pyproject.toml(1 hunks)requirements_test.txt(1 hunks)
🔇 Additional comments (1)
custom_components/plugwise_usb/manifest.json (1)
11-12: LGTM – dependency & version bumped consistently
No further issues spotted.
|
Summary by CodeRabbit