Skip to content

Commit 70b619d

Browse files
committed
follow CR on how to perform the test
1 parent f7fca23 commit 70b619d

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

tests/test_usb.py

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from datetime import UTC, datetime as dt, timedelta as td
66
import importlib
77
import logging
8-
import math
98
import random
109
from typing import Any
1110
from unittest.mock import MagicMock, Mock, patch
@@ -932,9 +931,7 @@ async def fake_get_missing_energy_logs(address: int) -> None:
932931
last_second=None, last_8_seconds=None, timestamp=None
933932
)
934933
pu = await stick.nodes["0098765432101234"].power_update()
935-
assert math.isclose(
936-
pu.last_second, 21.2780505980402, rel_tol=1e-09, abs_tol=1e-09
937-
)
934+
assert pu.last_second == pytest.approx(21.2780505980402, rel=1e-09, abs=1e-09)
938935
assert pu.last_8_seconds == -27.150578775440106
939936

940937
# Test energy state without request
@@ -1395,11 +1392,8 @@ def test_energy_counter(self) -> None:
13951392
0.07204743061527973,
13961393
reset_timestamp,
13971394
)
1398-
assert math.isclose(
1399-
energy_counter_init.energy,
1400-
0.07204743061527973,
1401-
rel_tol=1e-09,
1402-
abs_tol=1e-09,
1395+
assert energy_counter_init.energy == pytest.approx(
1396+
0.07204743061527973, rel=1e-09, abs=1e-09
14031397
)
14041398
assert energy_counter_init.last_reset == reset_timestamp
14051399
assert energy_counter_init.last_update == reset_timestamp + td(minutes=10)
@@ -1409,11 +1403,8 @@ def test_energy_counter(self) -> None:
14091403
0.08263379198066137,
14101404
reset_timestamp,
14111405
)
1412-
assert math.isclose(
1413-
energy_counter_init.energy,
1414-
0.08263379198066137,
1415-
rel_tol=1e-09,
1416-
abs_tol=1e-09,
1406+
assert energy_counter_init.energy == pytest.approx(
1407+
0.08263379198066137, rel=1e-09, abs=1e-09
14171408
)
14181409
assert energy_counter_init.last_reset == reset_timestamp
14191410
assert energy_counter_init.last_update == reset_timestamp + td(

0 commit comments

Comments
 (0)