Improve test-coverage for set_number()

Author: bouwew

tests/test_adam.py

@@ -79,6 +79,9 @@ async def test_connect_adam_zone_per_device(self):
         )
         assert result
 
+        tinkered = await self.tinker_max_boiler_temp(smile, unhappy=True)
+        assert not tinkered
+
         try:
             await smile.delete_notification()
             notification_deletion = False  # pragma: no cover
@@ -87,7 +90,7 @@ async def test_connect_adam_zone_per_device(self):
         assert notification_deletion
 
         reboot = await self.tinker_reboot(smile, unhappy=True)
-        assert not reboot
+        assert reboot
 
         await smile.close_connection()
         await self.disconnect(server, client)
@@ -324,6 +327,7 @@ async def test_connect_adam_plus_anna_new(self):
 
         await self.tinker_gateway_mode(smile)
         await self.tinker_regulation_mode(smile)
+
         tinkered = await self.tinker_max_boiler_temp(smile)
         assert tinkered
 
@@ -354,6 +358,17 @@ async def test_connect_adam_plus_anna_new(self):
         await smile.close_connection()
         await self.disconnect(server, client)
 
+        self.smile_setup = "adam_plus_anna_new"
+        testdata = self.load_testdata(SMILE_TYPE, self.smile_setup)
+        server, smile, client = await self.connect_wrapper(raise_timeout=True)
+        await self.device_test(smile, "2023-12-17 00:00:01", testdata)
+
+        tinkered = await self.tinker_max_boiler_temp(smile, unhappy=True)
+        assert tinkered
+
+        await smile.close_connection()
+        await self.disconnect(server, client)
+
     @pytest.mark.asyncio
     async def test_adam_plus_jip(self):
         """Test Adam with Jip setup."""

tests/test_init.py

@@ -647,7 +647,7 @@ async def tinker_reboot(self, smile, unhappy=False):
         except pw_exceptions.ConnectionFailedError:
             if unhappy:
                 _LOGGER.info("  + failed as expected")
-                return False
+                return True
             else:  # pragma: no cover
                 _LOGGER.info("  - failed unexpectedly")
                 return False
@@ -902,6 +902,7 @@ async def tinker_max_boiler_temp(smile, unhappy=False):
         new_temp = 60.0
         _LOGGER.info("- Adjusting temperature to %s", new_temp)
         for test in ["maximum_boiler_temperature", "bogus_temperature"]:
+            _LOGGER.info("  + for %s", test)
             try:
                 await smile.set_number("dummy", test, new_temp)
                 _LOGGER.info("  + tinker_max_boiler_temp worked as intended")