Now tooltiped #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gtribello
This should solve the problem of the phantom newlines while copy-pasting things from the
<pre>with the plumed prettied code, at least on Firefox/Linux, and on Firefox/Windows and Edge/Windows.I also checked the colored code in the rendered markdown of gh, and they have used to color the various token, so I think is the way to go
Then we should talk about moving into using some external package to prepare the HTML parts (something like dominate, or check if beautifulsoup can help) to preserve the mental health of the next one that will dive into
PlumedFormatter.py. For things like remembering to close the brackets is a blessBy testing on the WSL with python 3.12 I saw that the regexes of the lexer do not work there, we should investigate