Skip to content

Remove async from unregister_from_activity#6

Merged
pmca31 merged 2 commits intoaccelerate-with-copilotfrom
copilot/sub-pr-2-yet-again
Feb 10, 2026
Merged

Remove async from unregister_from_activity#6
pmca31 merged 2 commits intoaccelerate-with-copilotfrom
copilot/sub-pr-2-yet-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 10, 2026

The unregister_from_activity endpoint was declared async def but performed only in-memory operations without any await statements, creating misleading async semantics.

Changes

  • Changed unregister_from_activity from async def to def to match the pattern used by other in-memory endpoints (signup_for_activity, get_activities)
# Before
@app.post("/activities/{activity_name}/unregister")
async def unregister_from_activity(activity_name: str, email: str):
    # ... in-memory operations only ...

# After
@app.post("/activities/{activity_name}/unregister")
def unregister_from_activity(activity_name: str, email: str):
    # ... in-memory operations only ...

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pmca31 <6774003+pmca31@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on 'Accelerate with copilot' PR Remove async from unregister_from_activity Feb 10, 2026
Copilot AI requested a review from pmca31 February 10, 2026 18:38
@pmca31 pmca31 marked this pull request as ready for review February 10, 2026 19:51
@pmca31 pmca31 merged commit c5e5fc4 into accelerate-with-copilot Feb 10, 2026
@pmca31 pmca31 deleted the copilot/sub-pr-2-yet-again branch February 10, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants