Skip to content

Commit 64b89c6

Browse files
committed
Merge pull request #68 from expose-prop-defaults
Expose all properties with default values #68
2 parents 4266f74 + 4ab974f commit 64b89c6

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212

1313
**Merged pull requests:**
1414

15+
* [#68](https://github.com/pmd/pmd-designer/pull/68) Expose all properties with default values by [@jsotuyod](https://github.com/jsotuyod)
16+
1517
See https://github.com/pmd/pmd-designer/milestone/11
1618

1719
## 7.0.0-rc1

src/main/java/net/sourceforge/pmd/util/fxdesigner/model/XPathEvaluator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import java.util.Collections;
1111
import java.util.List;
1212
import java.util.Map;
13+
import java.util.Map.Entry;
1314
import java.util.stream.Collectors;
1415

1516
import org.apache.commons.lang3.StringUtils;
@@ -83,10 +84,11 @@ public static List<Node> evaluateQuery(Node compilationUnit,
8384

8485
try {
8586

86-
Map<String, ? extends PropertyDescriptor<?>> descriptors = properties.stream().collect(Collectors.toMap(PropertyDescriptorSpec::getName, PropertyDescriptorSpec::build));
87+
Map<String, PropertyDescriptor<?>> descriptors = properties.stream().collect(Collectors.toMap(PropertyDescriptorSpec::getName, PropertyDescriptorSpec::build));
88+
// Take in all set values or defaults
8789
Map<PropertyDescriptor<?>, Object> allProperties =
88-
propertyValues.entrySet().stream()
89-
.collect(Collectors.toMap(e -> descriptors.get(e.getKey()), e -> descriptors.get(e.getKey()).valueFrom(e.getValue())));
90+
descriptors.entrySet().stream()
91+
.collect(Collectors.<Entry<String, PropertyDescriptor<?>>, PropertyDescriptor<?>, Object>toMap(e -> e.getValue(), e -> propertyValues.containsKey(e.getKey()) ? e.getValue().valueFrom(propertyValues.get(e.getKey())) : e.getValue().defaultValue()));
9092

9193
SaxonXPathRuleQuery xpathRule =
9294
new SaxonXPathRuleQuery(

0 commit comments

Comments
 (0)