Merge pull request #69 from adangel:async-exit

Perform the persistence asynchronously to not block the main (UI) thread #69

Author: adangel

CHANGELOG.md

@@ -13,6 +13,7 @@
 **Merged pull requests:**
 
 * [#68](https://github.com/pmd/pmd-designer/pull/68) Expose all properties with default values by [@jsotuyod](https://github.com/jsotuyod)
+* [#69](https://github.com/pmd/pmd-designer/pull/69) Perform the persistence asynchronously to not block the main (UI) thread #69 by [@adangel](https://github.com/adangel)
 
 See https://github.com/pmd/pmd-designer/milestone/11
 

src/main/java/net/sourceforge/pmd/util/fxdesigner/Designer.java

@@ -21,6 +21,7 @@
 import javafx.application.Application;
 import javafx.application.Platform;
 import javafx.collections.ObservableList;
+import javafx.concurrent.Task;
 import javafx.fxml.FXMLLoader;
 import javafx.scene.Parent;
 import javafx.scene.Scene;
@@ -97,11 +98,18 @@ public void start(Stage stage, DesignerRoot owner) throws IOException {
         ));
 
         stage.setOnCloseRequest(e -> {
-            owner.getService(DesignerRoot.PERSISTENCE_MANAGER).persistSettings(mainController);
-            Platform.exit();
-            // VM sometimes fails to exit for no apparent reason
-            // all our threads are killed so it's not our fault
-            System.exit(0);
+            Task<Void> closerTask = new Task<Void>() {
+                @Override
+                protected Void call() throws Exception {
+                    owner.getService(DesignerRoot.PERSISTENCE_MANAGER).persistSettings(mainController);
+                    return null;
+                }
+            };
+            closerTask.setOnSucceeded(event -> {
+                Platform.exit();
+            });
+            new Thread(closerTask).start();
+            e.consume(); // don't close the window yet, will be closed by Platform#exit
         });
 
         Parent root = loader.load();