#1350 Check code after saving runs PMD unnecessarily

Author: adangel

ReleaseNotes.md

@@ -6,6 +6,7 @@ Eclipse Update Site: <https://sourceforge.net/projects/pmd/files/pmd-eclipse/upd
 
 ## ????: 4.0.7.v????
 
+* Fixed Check code after saving runs PMD unnecessarily ([bug #1350](https://sourceforge.net/p/pmd/bugs/1350/))
 
 ## 01-April-2015: 4.0.6.v20150401-1945
 

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/plugin/FileChangeReviewer.java

@@ -13,6 +13,8 @@
 import org.eclipse.core.resources.IResourceChangeEvent;
 import org.eclipse.core.resources.IResourceChangeListener;
 import org.eclipse.core.resources.IResourceDelta;
+import org.eclipse.core.resources.IWorkspaceDescription;
+import org.eclipse.core.resources.ResourcesPlugin;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.IStatus;
@@ -65,6 +67,11 @@ public boolean equals(Object other) {
      * @param event
      */
     public void resourceChanged(IResourceChangeEvent event) {
+        IWorkspaceDescription workspaceSettings = ResourcesPlugin.getWorkspace().getDescription();
+        if (workspaceSettings.isAutoBuilding()) {
+            PMDPlugin.getDefault().logInformation("Not running PMD, as autoBuilding is enabled for this workspace");
+            return;
+        }
 
         Set<ResourceChange> itemsChanged = new HashSet<ResourceChange>();
 

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java

@@ -102,6 +102,8 @@ public class ReviewCodeCmd extends AbstractDefaultCommand {
     private int fileCount;
     private long pmdDuration;
     private String onErrorIssue = null;
+    /** Whether to run the review command, even if PMD is disabled in the project settings. */
+    private boolean runAlways = false;
 
     private IProjectProperties propertyCache = null;
 
@@ -291,6 +293,10 @@ public void setTaskMarker(boolean taskMarker) {
         this.taskMarker = taskMarker;
     }
 
+    public void setRunAlways(boolean runAlways) {
+        this.runAlways = runAlways;
+    }
+
     /**
      * @param openPmdPerspective
      *            Tell whether the PMD perspective should be opened after
@@ -310,6 +316,7 @@ public void reset() {
         setTerminated(false);
         openPmdPerspective = false;
         onErrorIssue = null;
+        runAlways = false;
     }
 
     /**
@@ -382,7 +389,7 @@ private void processResource(IResource resource) throws CommandException {
 
             final IProject project = resource.getProject();
             final IProjectProperties properties = getProjectProperties(project);
-            if (!properties.isPmdEnabled()) {
+            if (!runAlways && !properties.isPmdEnabled()) {
                 return;
             }