Skip to content

Commit f5d6e96

Browse files
committed
Add markerTypeCategory
1 parent 47679a5 commit f5d6e96

File tree

4 files changed

+26
-9
lines changed

4 files changed

+26
-9
lines changed

net.sourceforge.pmd.eclipse.plugin.test/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCmdTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
import org.eclipse.core.resources.IResource;
4848
import org.eclipse.core.resources.IncrementalProjectBuilder;
4949
import org.eclipse.core.runtime.CoreException;
50-
import org.eclipse.jdt.internal.core.search.IRestrictedAccessConstructorRequestor;
5150
import org.junit.After;
5251
import org.junit.Assert;
5352
import org.junit.Before;

net.sourceforge.pmd.eclipse.plugin/plugin.properties

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
# PMD Eclipse Plugin externalized strings
22

3+
marker.category = PMD Markers
34
marker.pmd = PMD Marker
5+
marker.pmd.prio1 = PMD Marker (Prio 1)
6+
marker.pmd.prio2 = PMD Marker (Prio 2)
7+
marker.pmd.prio3 = PMD Marker (Prio 3)
8+
marker.pmd.prio4 = PMD Marker (Prio 4)
9+
marker.pmd.prio5 = PMD Marker (Prio 5)
410
marker.task = PMD Task Marker
511
marker.dfa = PMD DFA Marker
612

net.sourceforge.pmd.eclipse.plugin/plugin.xml

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,43 +24,55 @@
2424

2525
<extension
2626
id="pmdMarker1"
27-
name="%marker.pmd"
27+
name="%marker.pmd.prio1"
2828
point="org.eclipse.core.resources.markers">
2929
<super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
3030
<persistent value="true"></persistent>
3131
</extension>
3232

3333
<extension
3434
id="pmdMarker2"
35-
name="%marker.pmd"
35+
name="%marker.pmd.prio2"
3636
point="org.eclipse.core.resources.markers">
3737
<super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
3838
<persistent value="true"></persistent>
3939
</extension>
4040

4141
<extension
4242
id="pmdMarker3"
43-
name="%marker.pmd"
43+
name="%marker.pmd.prio3"
4444
point="org.eclipse.core.resources.markers">
4545
<super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
4646
<persistent value="true"></persistent>
4747
</extension>
4848

4949
<extension
5050
id="pmdMarker4"
51-
name="%marker.pmd"
51+
name="%marker.pmd.prio4"
5252
point="org.eclipse.core.resources.markers">
5353
<super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
5454
<persistent value="true"></persistent>
5555
</extension>
5656

5757
<extension
5858
id="pmdMarker5"
59-
name="%marker.pmd"
59+
name="%marker.pmd.prio5"
6060
point="org.eclipse.core.resources.markers">
6161
<super type="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></super>
62-
<persistent value="true"> </persistent>
63-
<attribute name="rulename"> </attribute>
62+
<persistent value="true"></persistent>
63+
</extension>
64+
65+
<extension point="org.eclipse.ui.ide.markerSupport">
66+
<markerTypeCategory name="%marker.category">
67+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdMarker"></markerTypeReference>
68+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdMarker1"></markerTypeReference>
69+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdMarker2"></markerTypeReference>
70+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdMarker3"></markerTypeReference>
71+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdMarker4"></markerTypeReference>
72+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdMarker5"></markerTypeReference>
73+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdTaskMarker"></markerTypeReference>
74+
<markerTypeReference id="net.sourceforge.pmd.eclipse.plugin.pmdDFAMarker"></markerTypeReference>
75+
</markerTypeCategory>
6476
</extension>
6577

6678
<extension point="org.eclipse.ui.ide.markerImageProviders">

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/PMDRuntimeConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
*/
1313
public class PMDRuntimeConstants {
1414

15-
public static final String PMD_MARKER = PMDPlugin.PLUGIN_ID + ".pmdMarker"; // obsolete
15+
public static final String PMD_MARKER = PMDPlugin.PLUGIN_ID + ".pmdMarker";
1616

1717
public static final String PMD_MARKER_1 = PMDPlugin.PLUGIN_ID + ".pmdMarker1";
1818
public static final String PMD_MARKER_2 = PMDPlugin.PLUGIN_ID + ".pmdMarker2";

0 commit comments

Comments
 (0)