Fix missing violations in diff report #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When base or patch reports contain violations, that are duplicated in terms of eql? (same rule, same line, same message), then these were deduplicated when creating the union of all violations for a file. This resulted in odd numbers in the diff, e.g. less than all violations being removed when no violation were actually being left over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When base or patch reports contain violations, that are duplicated in terms of eql? (same rule, same line, same message), then these were deduplicated when creating the union of all violations for a file. This resulted in odd numbers in the diff, e.g. less than all violations being removed when no violation were actually being left over.
This problem was found by @UncleOwen in pmd/pmd#5922 (comment)