Merged
Conversation
Click here to view all benchmarks. |
Owner
Author
|
@charlotteaward tagging you here so that you know. Anything with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a problem with the starlet reconstruction algorithm (the treatment of edges was incorrect), which caused edge artifacts. It also removes the proximal operators because they lead to other artifacts across the image in the backward path.
As is, the starlet morphology model is unconstrained and overcomplete, which means you might as well use a 2D image as morphology. However, the solution is to put explicit constraints or priors on the coefficients to encourage some form of sparsity. A notebook describing this option is forthcoming.