Skip to content

fix: fix NRE when configuration is invalid #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: fix NRE when configuration is invalid #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitExtensions.AzureDevOpsCommitMessage/Plugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
return false;
}

ThreadHelper.JoinableTaskFactory.RunAsync(

Check warning on line 114 in src/GitExtensions.AzureDevOpsCommitMessage/Plugin.cs

View workflow job for this annotation

GitHub Actions / build 

Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
async () =>
{
await DisplayQueryResultAsync(_httpClient, _projectUrl, _query, _stringTemplate);
Expand Down Expand Up @@ -196,7 +196,7 @@
var localQuery = _wiqlQuerySettings.CustomControl.Text;
var localStringTemplate = _stringTemplateSetting.CustomControl.Text;

ThreadHelper.JoinableTaskFactory.RunAsync(

Check warning on line 199 in src/GitExtensions.AzureDevOpsCommitMessage/Plugin.cs

View workflow job for this annotation

GitHub Actions / build 

Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
async () =>
{
using (var httpClient = GetHttpClient(_credentialsSettings.CustomControl.UserName,
Expand Down Expand Up @@ -322,12 +322,12 @@

private void gitUiCommands_PreCommit(object sender, GitUIEventArgs e)
{
if (!_enabledSettings.ValueOrDefault(Settings))
if (_httpClient == null || !_enabledSettings.ValueOrDefault(Settings))
{
return;
}

ThreadHelper.JoinableTaskFactory.RunAsync(async () =>

Check warning on line 330 in src/GitExtensions.AzureDevOpsCommitMessage/Plugin.cs

View workflow job for this annotation

GitHub Actions / build 

Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
{
_currentCommitTemplates = await GetCommitTemplatesAsync(_httpClient, _projectUrlSettings.ValueOrDefault(Settings), _query, _stringTemplate);

Expand Down
Loading