feat: implement weather system

[GroXzaLYs]

Adds a basic dynamic weather system with automatic transitions between clear weather, rain, and thunderstorms.

Rain, thunder, and lightning are handled server-side and synchronized for all players.

---

Related issues & PRs

• Weather System Implementation  #6477

---

Changes

• Added Lightning weather entity
• Added weather-related methods to World
• Added /weather command

---

Compatibility

No breaking changes.
Worlds without weather support are unaffected.

---

Testing

Manual testing:

• /weather rain and /weather thunder work correctly
• Thunder sounds and lightning visuals are synced
• No crashes or performance issues observed

Minecraft_2025-10-28-21-49-18.mp4

[dktapps]

Also I don't know what editor you're using but it's made an enormous mess of your indentation. Indents should use tabs.

[dktapps]

Overall this is looking better since the last time I reviewed, but there's still some work left to do. Thanks for sticking with it 🙂

[dktapps]

This looks mostly OK now, code-wise.

I think my main sticking points remaining are:

• There doesn't appear to be any way to disable the system, short of just setting the weather to clear for a very large duration. People aren't going to want it to rain in their lobbies.
• I don't like that we're constrained to clear/rainy/thunder.
  • setRainLevel and setThunderLevel will not update the WeatherType, so that means plugins can make the /weather command return wrong results anyway.
  • Instead of generally constraining it by the type, it would be better to have the /weather command dynamically decide the weather type based on the rain and thunder amount (e.g. rain=0 + thunder=0 = clear, rain>0 + thunder=0 = rainy, thunder > 0 = thunder (whether or not it's raining)).

[kostamax27]

PocketMine-MP/src/network/mcpe/NetworkSession.php

Line 1282 in e9a3bc6

//TODO: weather needs to be synced here (when implemented)

PocketMine-MP/src/network/mcpe/handler/PreSpawnPacketHandler.php

Lines 80 to 81 in e9a3bc6

	$levelSettings->rainLevel = 0; //TODO: implement these properly
	$levelSettings->lightningLevel = 0;

[kostamax27]

https://minecraft.fandom.com/wiki/Rain#:~:text=Rain%20fills%20up%20cauldrons%20with%20water%2C%20albeit%20slowly

[remminiscent]

It seems like snow isn’t acknowledged here either.

[dktapps]

Ok, I didn't want to come off as a jerk and say this so bluntly, but this has gone on long enough that the notification spam from here is really getting on my nerves. I'm on the verge of muting the PR.

There are very basic errors in each commit that could be easily addressed by using the proper tools locally instead of spamming commits. Spamming commits chasing after CI failures is unproductive and it's also annoying for everyone getting notifications.

• Use an IDE like PhpStorm for writing and refactoring code. Notepads and generic text editors aren't enough without other tools
• Run vendor/bin/phpstan locally before you commit, it'll catch the obvious errors
• Run vendor/bin/phpunit tests/phpunit to run the unit tests
• php-cs-fixer can help with some (not all) formatting problems

[GroXzaLYs]

Got it, sorry about all the commit spam. I’ll run the checks on my end and won’t push small changes based on CI results anymore. Thanks for bringing this up!

[kostamax27]

Is this correct?

[kostamax27]

What is this for?

[kostamax27]

I no longer know how this can be expanded...