Open
Conversation
# Conflicts: # src/block/BlockTypeIds.php
dktapps
requested changes
Nov 2, 2025
Member
dktapps
left a comment
There was a problem hiding this comment.
I don't know WTF is going on with Mossy Carpet
dktapps
reviewed
Nov 2, 2025
dktapps
reviewed
Nov 2, 2025
Member
|
Sorry for all the WTFs btw. Since I'm not familiar with pale moss carpets I was tripping out wondering if you'd vibecoded the class for it 😂 |
dktapps
reviewed
Nov 3, 2025
dktapps
reviewed
Nov 4, 2025
ShockedPlot7560
requested changes
Nov 4, 2025
Member
ShockedPlot7560
left a comment
There was a problem hiding this comment.
I wonder if I missed something with the TODO removing ? Does minecraft changed the behavior ?
Contributor
Author
|
I added the DIRT tag to the moss block. That's what the game does to check for support for most blocks |
Contributor
|
This PR has been marked as "Waiting on Author", but we haven't seen any activity in 7 days. If there is no further activity, it will be closed in 28 days. Note for maintainers: Adding an assignee to the PR will prevent it from being marked as stale. |
dktapps
reviewed
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements moss blocks and moss carpets, including their pale variants. This also update relevant block logic to recognize moss blocks as valid support.
This PR does not implement Azalea and Flowering Azalea
1.17.0 - Caves and Cliffs, 1.21.50 - The Garden Awakens
Related issues & PRs
#6116
Changes
API changes
MossBlock,MossCarpet,PaleMossBlock,PaleMossCarpet, andPaleMossCarpetVineMOSS_BLOCK,MOSS_CARPET,PALE_MOSS_BLOCK,PALE_MOSS_CARPET, andPALE_MOSS_CARPET_VINEinVanillaBlocksBlockTypeIdsMOSS_REPLACEABLEtag inBlockTypeTagsand applied it to relevant existing blocks to allow moss spreading and placementBehavioural changes
Follow-up
Implement Azalea and Flowering Azalea
Tests
https://youtu.be/mBI6AJ52Lx8