fix DREI to work with latest three-sdlib#2276
fix DREI to work with latest three-sdlib#2276RodrigoHamuy wants to merge 1 commit intopmndrs:masterfrom
Conversation
|
@RodrigoHamuy is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Picked this into #2283. |
|
@CodyJasonBennett thanks ! |
|
No, it would not be preferable, as that is equally breaking and on the side of incorrect WRT to the types themselves. I think if remaining type issues only affect R3F usage, we loosen types there. Otherwise, we need to be creative to minimize breakage to vanilla users and collaborate with three types on this if possible. |
|
Okidok, in that case if you are happy @CodyJasonBennett I will close three-types/three-ts-types#1398 + pmndrs/react-three-fiber#3416 in favour of pmndrs/three-stdlib#392 + #2276 |
Why
After releasing pmndrs/three-stdlib#392 we need to do this small change in DREI to fix some TS issues.
What
OrbitControlsChangeEventis now more specific.Checklist
Keeping it in draft until pmndrs/three-stdlib#392 is merged.