fix(MeshReflectorMaterial): avoid updates when possible #2372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davcri is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
davcri
commented
Feb 24, 2025
| @@ -194,12 +192,12 @@ export const MeshReflectorMaterial: ForwardRefComponent<MeshReflectorMaterialPro | |||
|
|
|||
| useFrame(() => { | |||
| const parent = (materialRef.current as any).parent || (materialRef.current as any)?.__r3f.parent?.object | |||
| if (!parent) return | |||
| if (!parent || !materialRef.current.visible || !parent.visible || !shouldUpdate.current) return | |||
There was a problem hiding this comment.
I used shouldUpdate to avoid unnecessary instructions in useFrame which is called unconditionally.
Three's onBeforeRender instead is called only when the renderer needs it (EG: it shouldn't be called if the mesh isn't part of the scene being rendered).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
These changes avoids unnecessary updates for MeshReflectorMaterial.
Previously it was updating even with
visible=falseon the material or on the parent mesh.A couple of notes:
threeand@types/threepackage becauseonBeforeRender()method was not typed correctly up til Material: Add onBeforeRender() back. three-types/three-ts-types#1169 and it was causing errors