Fix/2418 : allow useKTX2 to accept an external KTX2Loader instance
#2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
box-textured-ktx2.glb is generated from this command: npx @gltf-transform/cli optimize BoxTextured.glb --texture-compress ktx2 BoxTextured-ktx2.glb The original GLB is taken from https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/BoxTextured
|
@davcri is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
See #2418
What
Allow
useKTX2()to accept an externalKTX2Loaderinstance via this api:I don't really like passing the 2nd argument as "undefined", probably the function signature could be written better, I'm open to feedback. When we settle on this I would gladly update the documentation as well.Fixed with 34b2476Checklist