fix/1529-invalidate-presentation-controls #2432
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves: #1529
When using
<Canvas frameloop="demand" />
, thePresentationControls
component was non-functional because interactions and easing animations did not automatically trigger re-renders. Sinceframeloop="demand"
disables continuous rendering, it requires manual invalidation of the render loop to update the scene. Without this, changes to rotation or scale weren't reflected visually.This PR fixes that issue by ensuring the component properly invalidates the render loop on interaction and animation updates, restoring expected behavior when
frameloop="demand"
is in use.What
frameloop="demand"
by manually triggering re-renders withinvalidate()
fromuseThree
.invalidate()
:onDrag
andonDragEnd
gesture handlers to ensure updates apply during/after interactions.useFrame
loop when easing causes a change to rotation or scale.frameloop="demand"
render modes.Checklist