fix(.storybook): saycheese component ignores pauseat prop, causing fixed 5s wait regardless of configuration#2710
Open
hieuit095 wants to merge 1 commit intopmndrs:masterfrom
Conversation
…ait regardless of configuration The `SayCheese` component accepts a `pauseAt` prop (defaulting to 3000ms) but the `setTimeout` always uses a hardcoded 5000ms delay, ignoring the prop entirely. This makes the `pauseAt` parameter useless and causes chromatic visual tests to wait a fixed 5 seconds regardless of what callers configure, potentially slowing down CI pipelines unnecessarily. Affected files: Setup.tsx Signed-off-by: hieuit095 <139037144+hieuit095@users.noreply.github.com>
|
@hieuit095 is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎨 UI/UX Improvement
Problem
The
SayCheesecomponent accepts apauseAtprop (defaulting to 3000ms) but thesetTimeoutalways uses a hardcoded 5000ms delay, ignoring the prop entirely. This makes the
pauseAtparameter useless and causes chromatic visual tests to wait a fixed 5 seconds regardless
of what callers configure, potentially slowing down CI pipelines unnecessarily.
Severity:
mediumFile:
.storybook/Setup.tsxSolution
Change line 57 from:
const timer = setTimeout(() => { ... }, 5000)
To:
const timer = setTimeout(() => { ... }, pauseAt)
Changes
.storybook/Setup.tsx(modified)Why
What
Checklist
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #2709