[Not For Merge] wip: internals rev2 #3104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
Size Change: +1.35 kB (+1.37%) Total Size: 99.6 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/FZRB764RX |
See documentations for usage instructions.
Hmm, I'm not super happy with it. |
dmaskasky
reviewed
Jul 23, 2025
| if (import.meta.env?.MODE !== 'production' && !atom) { | ||
| throw new Error('Atom is undefined or null') | ||
| } | ||
| let atomState = atomStateMap.get(atom) |
There was a problem hiding this comment.
This might be the same issue. ensureAtomState closes over the storeState destructure which causes it to reuse those captured values. If we want swappable pieces, my guess is that we would have to destructure within ensureAtomState and other building block functions.
There was a problem hiding this comment.
I think a good test would be to do,
const asm0 = { get: vi.fn(() => ({ d: new Set() })), has: () => true }
const buildingBlocks0 = asm0
const store0 = INTERNAL_buildStore(...buildingBlocks0)
const [...buildingBlocks1] = INTERNAL_getBuildingBlocks(store0)
const asm1 = { get: vi.fn(() => ({ d: new Set() })), has: () => true }
buildingBlocks1[0] = asm1
const store1 = INTERNAL_buildStore(...buildingBlocks1)
const a = atom(0)
store1.get(a)
expect(asm1.get).toBeCalled()
expect(asm0.get).not.toBeCalled()There was a problem hiding this comment.
With this rev2, my expectation is to call createBuildingBlocks again for the second store. You could argue that building blocks of the first store has changed, but we can't assure they don't use closure state anyways. We need some assumptions.
|
Closing in favor of #3105. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To expand our idea.