test(react/vanilla-utils/atomWithStorage): add test for 'getOnInit' option reading stored value on init#3252
Merged
dai-shi merged 2 commits intopmndrs:mainfrom Mar 4, 2026
Conversation
…ption reading stored value on init
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/6UZDGZFJQ |
See documentations for usage instructions.
dai-shi
requested changes
Mar 4, 2026
|
|
||
| it('should get stored value on init with getOnInit option', () => { | ||
| const countAtom = atomWithStorage('count', 0, dummyStorage, { | ||
| getOnInit: true, |
Member
There was a problem hiding this comment.
This test passes even if we make getOnInit: false.
Contributor
Author
…'getOnInit' reads stored value before mount
dai-shi
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
N/A
Summary
atomWithStoragewithgetOnInit: trueoption10) is used as initial value instead ofinitialValue(0) on first renderCheck List
pnpm run fixfor formatting and linting code and docs