Skip to content

Pass DevTools config through createReconciler to fix React DevTools #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pass DevTools config through createReconciler to fix React DevTools #3594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c147596
pass DevTools config through createReconciler
AlaricBaraou Oct 27, 2025
b59d125
add temporary type anotations
AlaricBaraou Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/fiber/src/core/reconciler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import packageData from '../../package.json'
import * as THREE from 'three'
import * as React from 'react'
import Reconciler from 'react-reconciler'
Expand Down Expand Up @@ -55,11 +56,8 @@ function createReconciler<
): Reconciler.Reconciler<Container, Instance, TextInstance, SuspenseInstance, FormInstance, PublicInstance> {
const reconciler = Reconciler(config as any)

reconciler.injectIntoDevTools({
bundleType: typeof process !== 'undefined' && process.env.NODE_ENV !== 'production' ? 1 : 0,
rendererPackageName: '@react-three/fiber',
version: React.version,
})
// @ts-ignore DefinitelyTyped is not up to date
reconciler.injectIntoDevTools()

return reconciler as any
}
Expand Down Expand Up @@ -601,4 +599,7 @@ export const reconciler = /* @__PURE__ */ createReconciler<
}
},
resetFormInstance() {},
// @ts-ignore DefinitelyTyped is not up to date
rendererPackageName: '@react-three/fiber',
rendererVersion: packageData.version,
})