Skip to content

Commit b9c0188

Browse files
author
Kailean O'Keefe
committed
bug:
- Fixed a script formatting bug that prevents the eslint commands from being run on windows - Added an unused import plugin to eslint - Updated the eslint script to automatically cleanup and organize imports on fix.
1 parent 6057576 commit b9c0188

File tree

8 files changed

+52
-423
lines changed

8 files changed

+52
-423
lines changed

.eslintrc

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,31 @@
1818
"plugin:import/recommended",
1919
"plugin:@react-three/recommended"
2020
],
21-
"plugins": ["@typescript-eslint", "react", "react-hooks", "import", "prettier", "@react-three"],
21+
"plugins": [ "@typescript-eslint", "react", "react-hooks", "import", "simple-import-sort", "unused-imports", "prettier", "@react-three" ],
2222
"rules": {
2323
"import/no-unresolved": "off",
2424
"import/named": "off",
2525
"import/namespace": "off",
2626
"import/no-named-as-default-member": "off",
27-
"import/extensions": ["error", "ignorePackages"]
27+
"import/extensions": [ "error", "ignorePackages" ],
28+
29+
"import/order": ["error", {
30+
"groups": [
31+
"builtin",
32+
"external",
33+
"internal",
34+
["parent", "sibling", "index"],
35+
"object",
36+
"type"
37+
],
38+
"newlines-between": "never",
39+
"alphabetize": {
40+
"order": "asc",
41+
"caseInsensitive": true
42+
}
43+
}],
44+
45+
// "simple-import-sort/imports": "error",
46+
"unused-imports/no-unused-imports": "error"
2847
}
29-
}
48+
}

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
"license": "MIT",
44
"type": "module",
55
"devDependencies": {
6+
"@react-three/drei": "rc",
67
"@react-three/eslint-plugin": "^0.1.1",
78
"@react-three/fiber": "rc",
8-
"@react-three/drei": "rc",
99
"@types/chai": "^5.0.1",
1010
"@types/eslint": "^8.56.10",
1111
"@types/mocha": "^10.0.10",
@@ -24,6 +24,7 @@
2424
"eslint-plugin-prettier": "^5.1.3",
2525
"eslint-plugin-react": "^7.34.2",
2626
"eslint-plugin-react-hooks": "^4.6.2",
27+
"eslint-plugin-unused-imports": "^4.1.4",
2728
"json": "^11.0.0",
2829
"mocha": "^10.8.2",
2930
"playwright": "^1.45.1",

packages/handle/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
"build": "tsc",
1010
"test": "mocha ./tests/*.spec.ts",
1111
"check:prettier": "prettier --check src",
12-
"check:eslint": "eslint 'src/**/*.ts'",
12+
"check:eslint": "eslint \"src/**/*.{ts,tsx}\"",
1313
"fix:prettier": "prettier --write src",
14-
"fix:eslint": "eslint 'src/**/*.ts' --fix"
14+
"fix:eslint": "eslint \"src/**/*.{ts,tsx}\" --fix"
1515
},
1616
"keywords": [
1717
"r3f",

packages/pointer-events/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
"example": "vite example --host",
3434
"example:build": "vite build example",
3535
"check:prettier": "prettier --check src",
36-
"check:eslint": "eslint 'src/**/*.ts'",
36+
"check:eslint": "eslint \"src/**/*.{ts,tsx}\"",
3737
"fix:prettier": "prettier --write src",
38-
"fix:eslint": "eslint 'src/**/*.ts' --fix"
38+
"fix:eslint": "eslint \"src/**/*.{ts,tsx}\" --fix"
3939
},
4040
"dependencies": {},
4141
"devDependencies": {

packages/react/handle/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@
4040
"scripts": {
4141
"build": "tsc",
4242
"check:prettier": "prettier --check src",
43-
"check:eslint": "eslint 'src/**/*.ts'",
43+
"check:eslint": "eslint \"src/**/*.{ts,tsx}\"",
4444
"fix:prettier": "prettier --write src",
45-
"fix:eslint": "eslint 'src/**/*.ts' --fix"
45+
"fix:eslint": "eslint \"src/**/*.{ts,tsx}\" --fix"
4646
}
4747
}

packages/react/xr/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@
4848
"build": "tsc",
4949
"generate_docs": "typedoc",
5050
"check:prettier": "prettier --check src",
51-
"check:eslint": "eslint 'src/**/*.ts'",
51+
"check:eslint": "eslint \"src/**/*.{ts,tsx}\"",
5252
"fix:prettier": "prettier --write src",
53-
"fix:eslint": "eslint 'src/**/*.ts' --fix"
53+
"fix:eslint": "eslint \"src/**/*.{ts,tsx}\" --fix"
5454
}
5555
}

packages/xr/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
"scripts": {
2323
"build": "tsc",
2424
"check:prettier": "prettier --check src",
25-
"check:eslint": "eslint 'src/**/*.ts'",
25+
"check:eslint": "eslint \"src/**/*.{ts,tsx}\"",
2626
"fix:prettier": "prettier --write src",
27-
"fix:eslint": "eslint 'src/**/*.ts' --fix"
27+
"fix:eslint": "eslint \"src/**/*.{ts,tsx}\" --fix"
2828
},
2929
"peerDependencies": {
3030
"three": "*"

0 commit comments

Comments
 (0)