Skip to content

Conversation

GeoDaoyu
Copy link

Related Bug Reports or Discussions

Discussions #2732 & #1770

Summary

Check List

  • pnpm run fix for formatting and linting code and docs

Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 0:26am

Copy link

codesandbox-ci bot commented May 26, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dbritto-dev
Copy link
Collaborator

dbritto-dev commented May 26, 2025

@GeoDaoyu should follow the format of api docs:

  • navigation links
  • ts support
  • examples
  • troubleshooting section if needed

This looks like you copy/paste the code from README.md file

follow the format of api docs:
add navigation links & types signature & examples & troubleshooting
@GeoDaoyu
Copy link
Author

@GeoDaoyu should follow the format of api docs:

  • navigation links
  • ts support
  • examples
  • troubleshooting section if needed

This looks like you copy/paste the code from README.md file

I add the missing section. Please check❤️

@dbritto-dev
Copy link
Collaborator

@GeoDaoyu still missing some parts I don't see how someone can use this guide to create a custom middleware and doesn't seems that fits into the api docs

@GeoDaoyu
Copy link
Author

@GeoDaoyu still missing some parts I don't see how someone can use this guide to create a custom middleware and doesn't seems that fits into the api docs

Where should it be placed if it doesn't seems that fits into the api docs?

@dbritto-dev
Copy link
Collaborator

@GeoDaoyu should be under guides and the goal should be a guide that takes you through all the steps needed to create a custom middleware.

Note

A custom middleware guide could be the most complex guide in Zustand docs

@GeoDaoyu
Copy link
Author

@GeoDaoyu should be under guides and the goal should be a guide that takes you through all the steps needed to create a custom middleware.

Note

A custom middleware guide could be the most complex guide in Zustand docs

Ok. I'll move it under guides later.

I'll do my best to finish it through it might be the most complexed.

@GeoDaoyu
Copy link
Author

@dbritto-dev I rewrite it under the guides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants