configure: refactor submodule configs #7688
Open
+372
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2512_submodule
branch
4 times, most recently
from
cf01922 to
66ec0ff
Compare
Fixes the following error:
./configure: line 35750: test: =: unary operator expected
./configure: line 35753: test: =: unary operator expected
MPICH uses mplsrcdir etc. while hydra and romio uses mpl_srcdir. Unify them.
Add PAC_CHECK_HEADER_LIB_EXPLICIT for json so we can optionally accept external libjson-c library. Rename yaksasrcdir and yaksalib to yaksa_srcdir and yaksa_lib, as the convention used for other embedded modules. Same for json variables. Remove yaksalibdir as it is not needed.
While we don't recommend users to build libmpl separately, we can do it internally to expedite CI jobs.
Remove the check for the existence of src/mpi/romio. It's unnecessary.
This script is only used for MPL's configure to prefix config header. Move to src/mpl/maint rather than relying on confdb always being sync'ed.
Define and propagate $MPICH_CONFDB to avoid duplicating confdb into subdirs. Avoid duplicating submodules such as mpl, pmi, hwloc. Add funcations such as fn_hydra, fn_pmi, fn_test for preparing release tarballs.
Add functions so user can select to just prepare for the specified sub packages. Use "./autogen.sh -do=(hydra|pmi|test)" to perform the step.
Now that we don't duplicate submodules in main mpich, we need additional preparation for generating subpackage tarballs.
hzhou
force-pushed
the
2512_submodule
branch
from
66ec0ff to
54ca523
Compare
Contributor
Author
|
test:mpich/ch4/most |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
confdb/aclocal_modules.m4and unify the naming of build variables.oAuthor Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.