Skip to content

Conversation

@raffenet
Copy link
Contributor

@raffenet raffenet commented Jan 6, 2026

Pull Request Description

PAC_C_CHECK_COMPILER_OPTION checks for warning messages, but those can be silenced by the user e.g. with clang's -Qunused-arguments. Try to compile a simple program using the extensions needed by MPL for a more robust test for this functionality.

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

PAC_C_CHECK_COMPILER_OPTION checks for warning messages, but those can
be silenced by the user e.g. with clang's -Qunused-arguments. Try to
compile a simple program using the extensions needed by MPL for a more
robust test for this functionality.
@raffenet
Copy link
Contributor Author

raffenet commented Jan 6, 2026

test:mpich/ch4/most
test:mpich/ch3/most

@raffenet
Copy link
Contributor Author

raffenet commented Jan 7, 2026

One of the Jenkins nodes crashed during testing. This should be ready to merge.

@raffenet raffenet requested a review from hzhou January 7, 2026 14:57
@hzhou hzhou merged commit b63c99e into pmodels:5.0.x Jan 9, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants