feat(gaussians): separate the harmonics from mobile #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjurczynski
requested changes
Jul 23, 2025
src/point-cloud-octree.ts
Outdated
| pcoGeometry: PCOGeometry, | ||
| material?: PointCloudMaterial, | ||
| loadHarmonics: boolean = false, | ||
| splatsMobile: boolean = false, |
Collaborator
There was a problem hiding this comment.
we start to have too many parameters here. In a separate PR we should convert it to one object parameter.
Please add JSDOC comment that explains the option.
Collaborator
There was a problem hiding this comment.
the new version does not need JSDOC, parameter name is self explanatory
src/point-cloud-octree.ts
Outdated
| pcoGeometry: PCOGeometry, | ||
| material?: PointCloudMaterial, | ||
| loadHarmonics: boolean = false, | ||
| splatsMobile: boolean = false, |
Collaborator
There was a problem hiding this comment.
Wouldn't it be more straightforward to have a maximumSplatRendered parameter?
I feel splatMobile parameter have the potential to evolve like this:
constructor(
potree: IPotree,
pcoGeometry: PCOGeometry,
material?: PointCloudMaterial,
loadHarmonics: boolean = false,
splatsMobile: boolean = false,
isSlowMobile: boolean = true,
isFastMobile: boolean = false,
isReallyAMobile: boolean = false,
// we have some code that set splat mobile to true on some desktop for historical reason.
){}… max amount of splats
pjurczynski
approved these changes
Jul 23, 2025
turien-pix4d
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple the harmonics loading from the mobile mode, so the splats can be loaded without harmonics in desktop.