Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the plugin from a JSON-based locale system to a new CSV-based locale manager. The change involves updating the locale initialization, replacing all references from the shorthand lm to the full locale_manager property, and converting locale data from JSON format to CSV format.
- Updated plugin initialization to use the new CSV locale manager with legacy mode disabled
- Replaced all
self.lm.get()calls withself.locale_manager.get()throughout the codebase - Converted locale data from
en_US.jsonformat tolocales.csvformat
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| main.py | Updated plugin initialization and replaced all locale manager references |
| locales/en_US.json | Removed JSON locale file |
| locales.csv | Added CSV locale file with same translation data |
| actions/TimerSourceActionBase.py | Updated locale manager references |
| actions/SetSplitsPath.py | Updated locale manager references |
| actions/SetLayoutPath.py | Updated locale manager references |
| actions/OBSLiveSplitOneActionBase.py | Updated locale manager references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pniedzielski
force-pushed
the
csv-locale-manager
branch
from
169dbf4 to
a10b7b7
Compare
A lot of new features have been added to StreamController since this plugin was written. In order to use these, this patch bumps the minimum version of StreamController going forward.
One of the new features of StreamController is the CSV locale manager, which replaces the legacy JSON directory locale manager. This patch switches over to the new CSV format.
pniedzielski
force-pushed
the
csv-locale-manager
branch
from
a10b7b7 to
0c1d46c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.