Skip to content

Feature/past future data#271

Open
EladMichael wants to merge 2 commits intopnnl:masterfrom
EladMichael:feature/past_future_data
Open

Feature/past future data#271
EladMichael wants to merge 2 commits intopnnl:masterfrom
EladMichael:feature/past_future_data

Conversation

@EladMichael
Copy link
Collaborator

Refactor SystemPreview: move preview config from System to Node via input_map

  • Preview window specification (past/future/pad_mode) now lives on each
    Node's input_map rather than being centralized on SystemPreview
  • Adds support for past windows (not just future-only)
  • Future / past window length is set per Node per input
  • Per-key padding modes instead of one global mode
  • Adds start_iter for rollouts beginning at arbitrary timesteps (e.g. if you're feeding a model 5 steps of past data for it to create the next output, then you might want it to start at index 5)
  • Fixes preview_length going stale when nsteps changes after init
  • Amended Jan B's examples so that they still run with this new SystemPreview

…dded dictionary logging capability, and capability to turn off stdout print with verbosity=0 to declutter when automatic hyperparameter tuning. Added save_weights flag, again for hyperparameter tuning situations, as well as storing run_id for easy access to run parameters downstream. Minimal fix, should not break anything that already uses (or doesn't use) this logger.
…rmation, nodes control their own index mapping as well as their own padding methods and their own preview window sizes, and fixed preview length going stale after nsteps is changed.
@EladMichael EladMichael requested review from drgona and xboldocky March 2, 2026 20:27
@drgona
Copy link
Collaborator

drgona commented Mar 6, 2026

@EladMichael all PRs needs to be submitted to the develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants