Merge pull request #1210 from SherpasGroup/fix-teams-tab-provisioning

Increase retry delay and improve error handling in GetTabs

Author: gautamdsheth

src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectTeams.cs

@@ -1180,7 +1180,7 @@ private static void RemoveTeamTab(string tabId, string channelId, string teamId,
         public static JToken GetExistingTeamChannelTabs(string teamId, string channelId, string accessToken, Uri graphBaseUri = null)
         {
             const int maxRetryCount = 60;
-            const int retryDelay = 1000;
+            const int retryDelay = 5000; // Increased to 5 seconds
             var retryAttempt = 0;
 
             JToken response = null;
@@ -1198,7 +1198,9 @@ public static JToken GetExistingTeamChannelTabs(string teamId, string channelId,
                 }
                 catch (Exception ex)
                 {
-                    if (ex.InnerException != null && ex.InnerException.Message.Contains("No active channel found with channel id:"))
+                    // Check both inner exception and the main exception message for channel not found errors
+                    var exceptionMessage = ex.Message + (ex.InnerException?.Message ?? "");
+                    if (exceptionMessage.Contains("No active channel found"))
                     {
                         Thread.Sleep(retryDelay);
                     }
@@ -1214,6 +1216,11 @@ public static JToken GetExistingTeamChannelTabs(string teamId, string channelId,
                 }
             } while (response == null && retryAttempt <= maxRetryCount);
 
+            if (response == null)
+            {
+                throw new Exception($"Could not get tabs for channel {channelId} in team {teamId} within timeout.");
+            }
+
             return response;
         }