Skip to content

Fix Set-PnPListItem not saving taxonomy values when using -Batch parameter #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gautamdsheth merged 3 commits into from
Dec 15, 2024
Merged

Fix Set-PnPListItem not saving taxonomy values when using -Batch parameter #4597

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
680b8bb
Fix Set-PnPListItem not saving taxonomy values when using -Batch para…
jackpoz Nov 30, 2024
e437073
Merge branch 'dev' into fixes/BatchTaxonomyListItem
gautamdsheth Dec 15, 2024
d7b98d2
Merge branch 'dev' into fixes/BatchTaxonomyListItem
gautamdsheth Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/Commands/Utilities/ListItemHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,21 +423,22 @@ public static Dictionary<string, object> GetFieldValues(PnP.Core.Model.SharePoin
var label = string.Empty;
var itemId = Guid.Empty;

if (!Guid.TryParse(arrayItem as string, out termGuid))
if (!Guid.TryParse(arrayItem?.ToString(), out termGuid))
{
var batchedTerm = batch.GetCachedTerm(termGuid.ToString());
var batchedTerm = batch.GetCachedTerm(arrayItem?.ToString());
if (batchedTerm.key == null)
{
taxonomyItem = clientContext.Site.GetTaxonomyItemByPath(arrayItem as string) as Term;
taxonomyItem = clientContext.Site.GetTaxonomyItemByPath(arrayItem?.ToString()) as Term;
if (taxonomyItem == null)
{
throw new PSInvalidOperationException($"Cannot find term {arrayItem}");
throw new PSInvalidOperationException($"Cannot find term '{arrayItem}'");
}
var labelResult = taxonomyItem.GetDefaultLabel(defaultLanguage);
clientContext.ExecuteQueryRetry();
label = labelResult.Value;
itemId = taxonomyItem.Id;
batch.CacheTerm(termGuid.ToString(), termGuid, label);
batch.CacheTerm(arrayItem?.ToString(), itemId, label);
batch.CacheTerm(itemId.ToString(), itemId, label);
}
else
{
Expand Down Expand Up @@ -467,10 +468,12 @@ public static Dictionary<string, object> GetFieldValues(PnP.Core.Model.SharePoin
itemId = batchedTerm.id;
label = batchedTerm.label;
}
fieldValueCollection.Values.Add(field.NewFieldTaxonomyValue(itemId, label));
}
item[key as string] = fieldValueCollection;

fieldValueCollection.Values.Add(field.NewFieldTaxonomyValue(itemId, label));
}

item[key as string] = fieldValueCollection;
}
else
{
Expand Down
Loading