Upgrade to SPFx v1.20.0 #1455
Merged
Upgrade to SPFx v1.20.0 #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blending work Nishkalank. |
Contributor
Author
|
Hello @hugoabernier I have upgraded this solution and have successfully built it. Request you to kindly review this. Thanks, |
Adam-it
approved these changes
Mar 1, 2025
Member
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
@NishkalankBezawada Awesome work 👏👏👏
Managed to build it locally without issue
You Rock 🤩
|
He did more, Nishkalank rocks.
Skickat från Outlook för Android<https://aka.ms/AAb9ysg>
…________________________________
From: Adam Wójcik ***@***.***>
Sent: Saturday, March 1, 2025 11:03:45 PM
To: pnp/sp-dev-fx-extensions ***@***.***>
Cc: Thomas Nilsson ***@***.***>; Comment ***@***.***>
Subject: Re: [pnp/sp-dev-fx-extensions] Upgrade to SPFx v1.20.0 (PR #1455)
Merged #1455<#1455> into main.
—
Reply to this email directly, view it on GitHub<#1455 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZELZC2HNGFIZA7XYPK2LWD2SIVEDAVCNFSM6AAAAABTGLC62SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGUZDGNBVGM3DGNI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Fixing the dependency mismatch and also upgrading the spfx version.
react-application-machine-translations unable to build, due to dependency mismatch.
Seems like the update of the sample was done few months ago, as below,
but, somehow, it was not. Please refer to the package.json as below,
the mismatch of the devDependencies with
@microsoft/sp-build-webis with version 1.18.0, and rest are on version 1.12.1, which ideally shouldnt be as such.Hence, Creating this PR to fix this, and also upgrade the SPFx version to 1.20.0
Thanks,
Nish