Skip to content

bug fix for root site file path in copy path command #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugoabernier merged 8 commits into from
Mar 14, 2025
Merged

bug fix for root site file path in copy path command #1473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fcd859a
bug fix for root site file path in copy path command
HarminderSethi Feb 27, 2025
8ff7539
Automated samples.json update
actions-user Feb 27, 2025
3fd4278
replace function changed with replaceAll
HarminderSethi Mar 12, 2025
0279c62
replace function changed with replaceAll
HarminderSethi Mar 12, 2025
2e94be4
Merge branch 'main' into main
hugoabernier Mar 14, 2025
657bbde
Updated sample.json, devcontainer
Mar 14, 2025
043e5a3
updated devcontainer, sample
Mar 14, 2025
c86fbc0
Automated samples.json update
actions-user Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,3 +327,46 @@ samples/react-application-my-lists-notifications/release/assets/my-lists-notific
samples/react-application-my-lists-notifications/release/assets/MyListsNotificationsApplicationCustomizerStrings_en-us_f40e9d8f16425c3069e4c6998aa3fc70.js
samples/react-application-my-lists-notifications/release/component-dependency-audit/react-application-my-lists-notifications.json
samples/react-application-my-lists-notifications/release/manifests/c1a3cdb7-6581-4966-832a-49952eb1feb7.manifest.json
samples/react-application-chatbubble-copilot/lib/index.d.ts
samples/react-application-chatbubble-copilot/lib/index.d.ts.map
samples/react-application-chatbubble-copilot/lib/index.js
samples/react-application-chatbubble-copilot/lib/index.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.manifest.json
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/loc/en-us.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.css
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.js.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.d.ts
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.d.ts.map
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.js
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.js.map
25 changes: 12 additions & 13 deletions .metadata/samples.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7348,18 +7348,16 @@
]
},
{
"name": "pnp-sp-dev-spfx-extensions-react-utility-extensions",
"name": "pnp-sp-dev-spfx-extensions-react-YOUR-SOLUTION-NAME-GOES-HERE",
"source": "pnp",
"title": "Copy Path and Copy Name List view command set extensions",
"shortDescription": "List view command set extensions with below functionalities: Copy Path and Copy Name.",
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-utility-extensions",
"shortDescription": "List view command set extensions with below functionalities",
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/YOUR-SOLUTION-NAME-GOES-HERE",
"longDescription": [
"List view command set extensions with below functionalities:",
"1. Copy Path allows to copy the path of the document without breaking the permission inheritance.",
"2. Copy Name allows to copy the name of the document without using the currently available rename functionality."
"List view command set extensions with below functionalities"
],
"creationDateTime": "2023-10-04",
"updateDateTime": "2024-08-28",
"creationDateTime": "2023-10-22",
"updateDateTime": "2025-02-27",
"products": [
"SharePoint"
],
Expand All @@ -7370,24 +7368,25 @@
},
{
"key": "SPFX-VERSION",
"value": "1.19.0"
"value": "1.20.0"
}
],
"tags": [],
"categories": [
"SPFX-COMMAND-EXTENSION"
"SPFX-APPLICATION-EXTENSION"
],
"thumbnails": [
{
"name": "CopyPathCopyNameExtenstions.png",
"type": "image",
"order": 100,
"url": "https://github.com/pnp/sp-dev-fx-extensions/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
"alt": "Preview"
"url": "https://github.com/pnp/sp-dev-fx-webparts/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
"alt": "Web Part Preview"
}
],
"authors": [
{
"gitHubAccount": "HarminderSethi",
"gitHubAccount": "https://github.com/HarminderSethi",
"pictureUrl": "https://github.com/HarminderSethi.png",
"name": "Harminder Singh"
}
Expand Down
4 changes: 2 additions & 2 deletions samples/react-utility-extensions/.devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
{
"name": "SPFx 1.19.0",
"image": "docker.io/m365pnp/spfx:1.19.0",
"name": "SPFx 1.20.0",
"image": "docker.io/m365pnp/spfx:1.20.0",
// Set *default* container specific settings.json values on container create.
"settings": {},
// Add the IDs of extensions you want installed when the container is created.
Expand Down
34 changes: 1 addition & 33 deletions samples/react-utility-extensions/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,39 +20,7 @@ module.exports = {
'@rushstack/security/no-unsafe-regexp': 1,
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
'@typescript-eslint/adjacent-overload-signatures': 1,
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
//
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
'@typescript-eslint/ban-types': [
1,
{
'extendDefaults': false,
'types': {
'String': {
'message': 'Use \'string\' instead',
'fixWith': 'string'
},
'Boolean': {
'message': 'Use \'boolean\' instead',
'fixWith': 'boolean'
},
'Number': {
'message': 'Use \'number\' instead',
'fixWith': 'number'
},
'Object': {
'message': 'Use \'object\' instead, or else define a proper TypeScript type:'
},
'Symbol': {
'message': 'Use \'symbol\' instead',
'fixWith': 'symbol'
},
'Function': {
'message': 'The \'Function\' type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with \'new\'.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.'
}
}
}
],

// RATIONALE: Code is more readable when the type of every variable is immediately obvious.
// Even if the compiler may be able to infer a type, this inference will be unavailable
// to a person who is reviewing a GitHub diff. This rule makes writing code harder,
Expand Down
11 changes: 6 additions & 5 deletions samples/react-utility-extensions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,12 @@ N/A

## Version history

| Version | Date | Comments |
| ------- | ------------ | ----------------------- |
| 1.0 | Oct 22, 2023 | Initial release |
| 1.1 | Aug 28, 2024 | Upgraded to SPFx 1.19.0 |
| 1.2 | Oct 11, 2024 | Upgraded to SPFx 1.20.0 |
| Version | Date | Comments |
| ------- | ------------ | ---------------------------------------------- |
| 1.0 | Oct 22, 2023 | Initial release |
| 1.1 | Aug 28, 2024 | Upgraded to SPFx 1.19.0 |
| 1.2 | Oct 11, 2024 | Upgraded to SPFx 1.20.0 |
| 1.3 | Oct 11, 2024 | Bug fix for missing site address for root site |

## Help

Expand Down
25 changes: 12 additions & 13 deletions samples/react-utility-extensions/assets/sample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
[
{
"name": "pnp-sp-dev-spfx-extensions-react-utility-extensions",
"name": "pnp-sp-dev-spfx-extensions-react-YOUR-SOLUTION-NAME-GOES-HERE",
"source": "pnp",
"title": "Copy Path and Copy Name List view command set extensions",
"shortDescription": "List view command set extensions with below functionalities: Copy Path and Copy Name.",
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-utility-extensions",
"shortDescription": "List view command set extensions with below functionalities",
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/YOUR-SOLUTION-NAME-GOES-HERE",
"longDescription": [
"List view command set extensions with below functionalities:",
"1. Copy Path allows to copy the path of the document without breaking the permission inheritance.",
"2. Copy Name allows to copy the name of the document without using the currently available rename functionality."
"List view command set extensions with below functionalities"
],
"creationDateTime": "2023-10-04",
"updateDateTime": "2024-08-28",
"creationDateTime": "2023-10-22",
"updateDateTime": "2025-02-27",
"products": [
"SharePoint"
],
Expand All @@ -22,24 +20,25 @@
},
{
"key": "SPFX-VERSION",
"value": "1.19.0"
"value": "1.20.0"
}
],
"tags": [],
"categories": [
"SPFX-COMMAND-EXTENSION"
"SPFX-APPLICATION-EXTENSION"
],
"thumbnails": [
{
"name": "CopyPathCopyNameExtenstions.png",
"type": "image",
"order": 100,
"url": "https://github.com/pnp/sp-dev-fx-extensions/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
"alt": "Preview"
"url": "https://github.com/pnp/sp-dev-fx-webparts/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
"alt": "Web Part Preview"
}
],
"authors": [
{
"gitHubAccount": "HarminderSethi",
"gitHubAccount": "https://github.com/HarminderSethi",
"pictureUrl": "https://github.com/HarminderSethi.png",
"name": "Harminder Singh"
}
Expand Down
Loading
Loading