Skip to content

Conversation

@zkochan
Copy link
Member

@zkochan zkochan commented Dec 31, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where dependencies explicitly marked as ignored in ignoredBuiltDependencies were still being added to onlyBuiltDependencies, effectively re-enabling them. The fix adds conditional logic to filter out ignored dependencies before adding them to the build list.

Key changes:

  • Updated the updateConfig hook in pnpmfile.cjs to check for and respect ignoredBuiltDependencies configuration
  • Added test coverage to verify that ignored dependencies are not re-enabled while allowed ones are still included
  • Added CI workflow for automated testing and upgraded pnpm version

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpmfile.cjs Implements filtering logic to exclude ignoredBuiltDependencies from being added to onlyBuiltDependencies
test.js Adds test cases to verify the fix, wrapping existing assertions in a test block and adding a new test for the ignore functionality
pnpm-workspace.yaml Adds pnpm plugin configuration dependency
pnpm-lock.yaml Updates lockfile checksum to reflect pnpmfile changes
package.json Updates package manager version from pnpm@10.11.0 to pnpm@10.27.0
.github/workflows/ci.yml Adds GitHub Actions CI workflow for automated testing with Node.js 22
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zkochan zkochan force-pushed the do-not-allow-ignored-deps branch from 97407d4 to 4c76987 Compare December 31, 2025 14:14
@zkochan zkochan merged commit 1bbabb7 into main Dec 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants